Skip to content

Move stacked area check and window sizing in check for any variables#1987

Merged
mjprilliman merged 2 commits into
patchfrom
graph-plot-reset-fix
Mar 10, 2025
Merged

Move stacked area check and window sizing in check for any variables#1987
mjprilliman merged 2 commits into
patchfrom
graph-plot-reset-fix

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Description

-Check if variables are selected for time series graphing before checking stacked area box
-Check if variables are selected before resizing window to first week

Fixes #1986

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.
  • This change requires updating the PySAM files via export_config. Please see When do the PySAM files need to be regenerated?

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added this to the 2024 Release Patch 1 milestone Dec 20, 2024
@mjprilliman mjprilliman requested a review from brtietz December 20, 2024 22:58
@mjprilliman mjprilliman self-assigned this Dec 20, 2024

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That solved it, thank you!

@brtietz brtietz modified the milestones: 2024 Release Patch 1, SAM Spring 2025 Release Mar 7, 2025
@mjprilliman mjprilliman merged commit fa87b63 into patch Mar 10, 2025
@mjprilliman mjprilliman deleted the graph-plot-reset-fix branch March 10, 2025 20:57
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stacked area on left Y axis gets re-checked after every simulation

3 participants