Quickstart, macro, and sample file upgrades#1948
Merged
Merged
Conversation
Collaborator
Collaborator
Collaborator
Author
|
Hmm, that's super weird that you're getting the old file version upgrade notice for the mini-grid example- it shows as updated on my computer. I just tried re-saving it and pushing it, can you see if it works now? If not, could this be a Mac vs Windows issue? |
Collaborator
Author
Collaborator
|
I'm not getting the version upgrade notice anymore! But I'm still getting the extended table for the array macro, even after manually copying over the new code. But the table looks the same in the 2023.12.17 SAM, so might be a Mac thing... |
Collaborator
|
I tested it on Windows and it's the same. What I did was run the array macro on the file created with the Quick Start for Puerto Rico. |
mjprilliman
approved these changes
Dec 9, 2024
mjprilliman
left a comment
Collaborator
There was a problem hiding this comment.
Mini grid wizard works on Windows
…AndSampleFileUpgrades
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Updates the mini grid macro file to the latest SAM version (note to reviewers - please test that quickstart function), the PV subarray layout optimization macro for new bounds on the GCR input, and small updates to the sample scripts.