Updates for 2024 resstock data#1915
Merged
Merged
Conversation
cpaulgilman
approved these changes
Nov 19, 2024
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix.
There are two other places that check for year = 2021 like this:
if year is 2021
do 2021 things
else
do other year things
A fix more consistent with the rest of the code would be
if year == '2021':
wf_folder = f'{wf_type}'
else:
wf_folder = f'state={state}'
Thanks,
Paul.
added 2 commits
December 2, 2024 16:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Updates to get.py that allow it the example script to work with 2024 resstock data. Haven't tested other EULP releases.
Fixes # (issue)
Type of change
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.