This is great! Thanks for tackling this! A few quick thoughts:

1. Is there any way to gracefully catch that someone didn't click simulate? Right now I get an error in the lk scripting box.
2. The Tab title in the browser still says "SAM ME Wave Energy Case Comparison"
3. The battery compare cases macro is crashing on line 733 when I compare two default detailed PV-battery single owner cases: Macro did not finish.
   [733] referencing unassigned variable:aep_system

Looks good. A few suggestions:

Fix all instances of '<title>SAM ME Wave Energy Case Comparison Report</title>', for example Lines 531 and 763.

I tested with a PTES case that does not have monthly_energy and cause a macro error in Line 150. One solution is to check for get('monthly_energy') == Null and stop the macro with a message if one of the required variables is Null.

Remove Line 974 outln(reportCode); so raw HTML does not print in console.

In table, replace "Technology" with "Performance Model".

In report footer, replace "This report was generated using the System Advisor Model testMacro" with "This report was generated using the System Advisor Model Compare Cases macro".

Center footer with '<footer style="text-align:center;">

@mjprilliman I'm getting SAM crashes testing now -- is this still in progress?

@mjprilliman I'm getting SAM crashes testing now -- is this still in progress?

I was waiting for tests to pass, but I can look into any issues. Where is the crash happening?

Sorry, I think the crash was a false alarm. I tried cleaning and rebuilding and things are working now. The fixes for the items I listed above look good. Thanks!

A couple of things in the new build:

• For the .sam file in combine-cases-macro-test.zip, I'm getting the following LK error when I run the "Battery Compare Cases" macro from the Custom Generation Battery case:

Macro did not finish.
[791] referencing unassigned variable:baselineCase

• For that same file that has a PV-Battery and Custom Generation-Battery case, the "Compare Cases" macro seems to work properly, but the Battery Compare Cases generates the above error. Should there be two versions of the macro?

Sorry, I think the crash was a false alarm. I tried cleaning and rebuilding and things are working now. The fixes for the items I listed above look good. Thanks!

A couple of things in the new build:

• For the .sam file in combine-cases-macro-test.zip, I'm getting the following LK error when I run the "Battery Compare Cases" macro from the Custom Generation Battery case:

Macro did not finish.
[791] referencing unassigned variable:baselineCase

• For that same file that has a PV-Battery and Custom Generation-Battery case, the "Compare Cases" macro seems to work properly, but the Battery Compare Cases generates the above error. Should there be two versions of the macro?

Thanks for finding that, there was a broken if statement for that.

Yes, there's a few extra features for the battery macro that I think are worth it. It creates a stacked graph for the annual energy of each case showing the contributions from the system and from the battery discharge. And for two battery cases, there's a waterfall chart that shows the difference in annual energy charged including steps for system and grid charging to compare the two cases.

Ok, looks good.