Rename Generic System technology to Custom Generation Profile#1890
Conversation
skip generic system
Help revisions need to be done to the proprietary source files using the Help & Manual software. Editing the HTML files in the code repository will not work because they are replaced by the HTML output of Help & Manual. I will make the necessary changes to Help in a separate pull request for the Fall 2024 release. |
cpaulgilman
left a comment
There was a problem hiding this comment.
In configuration tree, remove "formerly".
Change "Power Plant" in navigation menu to "Generation Profile" For CustomGeneration and Custom Generation-Battery configuration.
On Custom Generation Plant form:
-
Change "Custom Generation Profile Power Plant" group label to "Custom Generation Profile".
-
Change "Power Plant Losses" divider label to "Losses"
-
Change group for all variables from "Generic System Plant" to "Custom Generation Profile".
On Custom Generation Costs form, change group for all variables from "Generic System Capital Costs" to "Custom Generation Capital Costs".
On Custom Generation Battery Costs form, change group for all variables from "Generic Battery Capital Costs" to "Custom Generation Battery Capital Costs".
I will update the Help source files, generate a new set of HTML files, and commit them to this branch so we can make sure Help is working properly before merging. |
cpaulgilman
left a comment
There was a problem hiding this comment.
For hybrid CustomGeneration-PVWatts-Wind-FuelCell-Battery configuration, the fuel cell capacity and custom generation capacity on the Hybrid System page is zero instead of being the value from the Custom Generation Profile and Fuel Cell input pages, respectively.
and fuel cell config
There were a few missing updates in variable names and string checks in the UI equations for Hybrid System and Hybrid Cost pages, should be fixed with latest push. |
|
I found one more thing. Fuel Cell cost is missing from the Hybrid System Costs page for CustomGeneration-PVWatts-Wind-FuelCell-Battery configurations:
|
Fixed the callback for this. |
cpaulgilman
left a comment
There was a problem hiding this comment.
Looks good! Thanks for sorting through all of those changes.
Description
-Rename all Generic System configs and references to Custom Generation Profile:
-Update configs in startup, reference former name in technology tree setup
-Update UI forms and defaults files
-Update references in metrics.lk, autographs.lk, version upgrade, etc.
-Key word replace in help system, update file names (@cpaulgilman need to see if help system builds correctly, if not will have to revert and try another way).
-Update hybrid configs with custom generation, battery configs as well
-Update API, export_config
Fixes #1849
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.