Skip to content

Getem reservoir replacements#1881

Merged
mjprilliman merged 2 commits into
developfrom
getem-reservoir-replacements
Oct 21, 2024
Merged

Getem reservoir replacements#1881
mjprilliman merged 2 commits into
developfrom
getem-reservoir-replacements

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

-Allow option to turn off reservoir replacements in geothermal models

Fixes #1263

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman requested a review from sjanzou October 16, 2024 19:01
@mjprilliman mjprilliman self-assigned this Oct 16, 2024
@mjprilliman mjprilliman added this to the SAM Fall 2024 Release milestone Oct 16, 2024

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating these values and through all the defaults!

@mjprilliman mjprilliman merged commit 158a3c0 into develop Oct 21, 2024
@mjprilliman mjprilliman deleted the getem-reservoir-replacements branch October 21, 2024 14:36
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release geothermal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to turn off geothermal reservoir replacements

3 participants