Fix JSON Read Issues for URDB Downloads#1862
Merged
Merged
Conversation
In some cases for URDB data, e.g., energy charge tier max value, JSON stores an integer for a value that SAM requires to be double. IsNumber() allows integers to be read in and then be converted to double. Also changing this for geotools so that integer values of lat/lon are read in from JSON as valid values.
…b.com/NREL/SAM into sam-1848-urdb-max-tier-download-issue
sjanzou
approved these changes
Oct 4, 2024
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for finding and fixing the issues!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Use
IsNumber()in place ofIsDouble()to check numeric values from URDB JSON because tier max values are stored as integers, not doubles.Use UTF16 instead of UTF8 to fix problem reading some URDB JSON in Windows.
Add RapidJSON error codes to error messages to help with future troubleshooting.
Fixes #1848
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.