Skip to content

Send-to-Excel updates for depreciation and ITC basis updates#1860

Merged
cpaulgilman merged 9 commits into
developfrom
sam_1803_basis_corrections
Oct 2, 2024
Merged

Send-to-Excel updates for depreciation and ITC basis updates#1860
cpaulgilman merged 9 commits into
developfrom
sam_1803_basis_corrections

Conversation

@cpaulgilman

@cpaulgilman cpaulgilman commented Sep 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Goes with NatLabRockies/ssc#1193

To test minimally:

  1. In Windows version of SAM, create default PVWatts case for each FOM financial model with:

    • 30 % Federal ITC
    • $5000 Utility IBI that reduces Federal ITC basis
    • 50% Federal Bonus depreciation

  2. Run simulation and compare:

    • NPV on Summary tab to NPV in Send-to-Excel with equations
    • Depreciation table in SAM and Excel

Changes

Task SO CS TP MP PF SB
Update depreciable basis to match SSC ☑ ☑ ☑ ☑ ☑ ☑
Add new ITC basis and qualifying costs ☑ ☑ ☑ ☑ ☑ ☑
Calculate ITC as % from new qualifying costs ☑ ☑ ☑ ☑ ☑ ☑
Depreciation table labels and format ☑ ☑ ☑ ☑ ☑ ☑
Depreciation table total rows ☑ ☑ ☑ ☑ ☑ ☑
Depreciation calculation format ☑ ☑ ☑ ☑ ☑ ☑
Remove unused total depreciation basis ☑ ☑ ☑ ☑ ☑ ☑
Income incentives heading and format ☑ ☑ ☑ ☑ ☑ ☑
SAM cash flow headings and column widths ☑ ☑ ☑ ☑ ☑ ☑
Rename UI input "Financing cost" to "Other financing cost" ☑ ☑ ☑ ☑ N/A N/A
Rename SSC output "Financing cost" to "Total financing cost" ☑ ☑ ☑ ☑ ☑ ☑
Remove "Total" from SSC input "Total depreciable basis prior to allocation" ☑ ☑ ☑ ☑ ☑ ☑
Remove "Total" from SSC input "Total ITC basis prior to qualification" ☑ ☑ ☑ ☑ ☑ ☑

Fixes #1803

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [X ] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman
Update test results for ITC/Depreciation basis changes
8982cfe
@cpaulgilman
Initial spreadsheet cash flow updates for ITC basis
86af994 
Remove debt closing cost, debt up-front fee, debt service reserve financing, working capital reserve funding, and receivables reserve funding from depreciable basis per Line 2505 in cmod_singleowner.cpp.

Add row for ITC qualifying costs so we can add ITC basis adjustments in the future.

Depreciation basis table

  * Add top column labels to depreciation table

  * Clean up borders

  * Revise column headings

  * Convert all cells in total row to sum of rows above to avoid confusion.

Depreciation calculations

* Fix indentation of depreciation calculation rows

* Remove total depreciation basis reductions
@cpaulgilman
More single owner depreciation fixes for cash flow
494b106 
* Fix spreadsheet indentation and capitalization in state and federal Taxes section for taxable IBI, CBI, PBI and add "Taxable Incentives" heading
* Revise depreciation column headings in cash flow table for Results page to match spreadsheet
* Change "Financing cost" UI input label to "Other financing cost".
* Improve depreciation table in UI to minimize numbers being cut off
@cpaulgilman
Merge branch 'develop' into sam_1803_basis_corrections
c7458cb
@cpaulgilman
Tweak cash flow depreciation table labels
ddd543d
@cpaulgilman
Update Send-to-Excel spreadsheets for Depreciation and ITC basis
3a0dd07 
| Task                                                         | SO      | CS      | TP      | MP      | PF      | SB      |
|  ---                                                         | ---     | ---     | ---     | ---     | ---     | ---     |
| Update depreciable basis to match SSC                        | ☑ | ☑ | ☑ | ☑ | ☑ | ☑ |
| Add new ITC basis and qualifying costs                       | ☑ | ☑ | ☑ | ☑ | ☑ | ☑ |
| Calculate ITC as % from new qualifying costs                 | ☑ | ☑ | ☑ | ☑ | ☑ | ☑ |
| Depreciation table labels and format                         | ☑ | ☑ | ☑ | ☑ | ☑ | ☑ |
| Depreciation table total rows                                | ☑ | ☑ | ☑ | ☑ | ☑ | ☑ |
| Depreciation calculation format                              | ☑ | ☑ | ☑ | ☑ | ☑ | ☑ |
| Remove unused total depreciation basis                       | ☑ | ☑ | ☑ | ☑ | ☑ | ☑ |
| Income incentives heading and format                         | ☑ | ☑ | ☑ | ☑ | ☑ | ☑ |
| SAM cash flow headings and column widths                     | ☑ | ☑ | ☑ | ☑ | ☑ | ☑ |
| Rename UI input "Financing cost" to "Other financing cost"   | ☑ | ☑ | ☑ | ☑ | N/A     | N/A     |
| Rename SSC output "Financing cost" to "Total financing cost" | ☑ | ☑ | ☑ | ☑ | ☑ | ☑ |
| Remove "Total" from SSC input "Total depreciable basis prior to allocation" | ☑ | ☑ | ☑ | ☑ | ☑ | ☑ |
| Remove "Total" from SSC input "Total ITC basis prior to qualification" | ☑ | ☑ | ☑ | ☑ | ☑ | ☑ |
@cpaulgilman
Merge branch 'develop' into sam_1803_basis_corrections
73f83c2
@cpaulgilman cpaulgilman added the financial Financial model label Sep 30, 2024
@cpaulgilman cpaulgilman added this to the SAM Fall 2024 Release milestone Sep 30, 2024
@cpaulgilman cpaulgilman self-assigned this Sep 30, 2024
@cpaulgilman cpaulgilman mentioned this pull request Sep 30, 2024
Merged
@brtietz

brtietz commented Oct 1, 2024

Copy link
Copy Markdown
Collaborator

@cpaulgilman Is there a reason there are a number of unrelated Geothermal changes? Are these pending on another branch or is develop the correct state for these files?

If the former, it might make sense to let the Geothermal PR go first and then merge develop back into this branch. If the latter, the right move is to call git checkout develop -- "path/to/file or/folder" to revert the changes.

brtietz
brtietz approved these changes Oct 1, 2024
View reviewed changes

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending resolution of geothermal issues. Great work!

@cpaulgilman

cpaulgilman commented Oct 1, 2024

Copy link
Copy Markdown
Collaborator Author

@cpaulgilman Is there a reason there are a number of unrelated Geothermal changes? Are these pending on another branch or is develop the correct state for these files?

If the former, it might make sense to let the Geothermal PR go first and then merge develop back into this branch. If the latter, the right move is to call git checkout develop -- "path/to/file or/folder" to revert the changes.

@brtietz Thanks for suggesting the fix for this. Develop is the correct state for the geothermal files -- not sure how those worked their way into this branch.

@cpaulgilman cpaulgilman merged commit 5c8d59a into develop Oct 2, 2024
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 11, 2024
@kbrunik kbrunik mentioned this pull request Feb 5, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brtietz brtietz brtietz approved these changes

@sjanzou sjanzou Awaiting requested review from sjanzou

Assignees

@cpaulgilman cpaulgilman

Labels

added to release notes PR and/or issue has been added to release notes for a public release financial Financial model

Projects

None yet

Milestone

SAM Fall 2024 Release

Development

Successfully merging this pull request may close these issues.

Update depreciation and ITC gross basis based on improved understanding of allowable fees

2 participants

@cpaulgilman @brtietz