Skip to content

Getem UI fixes#1857

Merged
mjprilliman merged 5 commits into
developfrom
getem-ui-fixes
Sep 30, 2024
Merged

Getem UI fixes#1857
mjprilliman merged 5 commits into
developfrom
getem-ui-fixes

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Description

-Update GETEMDefault jsons, default values based on input browser analysis
-Removed unused features for EGS custom plant temperature,
-Add check for production pumping cost in flash plants
-Update text for wet bulb temp assumption, plant utilization factor (adjust widget)

See task list for more information

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Actions failing because some default configurations do not run without messages, e.g. Geothermal / Merchant Plant (all Geothermal configurations except Single Owner fail)
image

Also, some export_config files needed updating - committed to this branch

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with GitHub Actions passing

@mjprilliman mjprilliman merged commit 333376e into develop Sep 30, 2024
@mjprilliman mjprilliman deleted the getem-ui-fixes branch September 30, 2024 16:41
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release geothermal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants