Skip to content

Remove code that restricts checkbox to single owner#1854

Merged
brtietz merged 2 commits into
developfrom
sam_1708_debt_limits_for_all_financial_models
Sep 23, 2024
Merged

Remove code that restricts checkbox to single owner#1854
brtietz merged 2 commits into
developfrom
sam_1708_debt_limits_for_all_financial_models

Conversation

@brtietz

@brtietz brtietz commented Sep 20, 2024

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

Remove code that limited the debt fraction checkboxes to single owner, as this code will be present in all financial models after NatLabRockies/ssc#1208 is merged

Fixes # #1708

To test:

  1. All financial models with DSCR options should have this checkbox
  2. The checkbox should work where it is present. See Add debt fraction limiting calcs to community solar ssc#1208 for rough instructions. Financial models that are reasonably profitable by default might need input adjustments to test the lower bound.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working with NatLabRockies/ssc#1208 for LPF, CS, HD, SO configurations.

For community solar
image

Should we add the debt percentage output when DSCR is selected like in the other financial model outputs:
image

@brtietz

brtietz commented Sep 23, 2024

Copy link
Copy Markdown
Collaborator Author

Great suggestion! Added in the latest push:

image

@brtietz brtietz merged commit c67f0c7 into develop Sep 23, 2024
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 11, 2024
@brtietz brtietz deleted the sam_1708_debt_limits_for_all_financial_models branch December 13, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release enhancement financial Financial model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants