Skip to content

Fix Adjustment Factors prefix for pysam#1826

Merged
cpaulgilman merged 1 commit into
patchfrom
pysam_for_patch
Aug 1, 2024
Merged

Fix Adjustment Factors prefix for pysam#1826
cpaulgilman merged 1 commit into
patchfrom
pysam_for_patch

Conversation

@dguittet

@dguittet dguittet commented Jul 31, 2024

Copy link
Copy Markdown
Collaborator

Pull Request Template

Fixes NatLabRockies/pysam#164. NatLabRockies/ssc#1196. Branch for PySAM upcoming.

Doesn't exactly address #1661, but that one will require some more effort, and I'm not sure if it's really needed

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

@dguittet dguittet added this to the 2023 Release Patch 2 milestone Jul 31, 2024
@dguittet dguittet requested a review from cpaulgilman July 31, 2024 14:51
@cpaulgilman

Copy link
Copy Markdown
Collaborator

Pairs with #1826. Branch for PySAM upcoming.

@dguittet Do you mean "Pairs with NatLabRockies/ssc#1196"?

@dguittet

Copy link
Copy Markdown
Collaborator Author

@cpaulgilman Yes, fixed, thanks!

@cpaulgilman cpaulgilman merged commit a9210bc into patch Aug 1, 2024
@cpaulgilman cpaulgilman deleted the pysam_for_patch branch August 1, 2024 23:07
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AdjustmentFactors variable names do not match SAM

2 participants