Skip to content

Getem cost updates#1823

Merged
mjprilliman merged 14 commits into
patchfrom
getem-cost-updates
Jul 31, 2024
Merged

Getem cost updates#1823
mjprilliman merged 14 commits into
patchfrom
getem-cost-updates

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Description

-Update PPI tables in installation cost pages
-Cleanup of field gathering costs, drilling cost categories
-Base drilling costs on drilled wells including failed wells
-Check for negative number of wells in GUI

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those PPI table updates - do you think they are stable now?

@mjprilliman

Copy link
Copy Markdown
Collaborator Author

Those PPI table updates - do you think they are stable now?

I believe they are for the moment, but a row gets appended to the end of the indices each year, so it is prone to translation errors having these in SAM and ssc. Worth revisiting in the future.

@mjprilliman mjprilliman merged commit 2379320 into patch Jul 31, 2024
@mjprilliman mjprilliman deleted the getem-cost-updates branch July 31, 2024 21:14
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug geothermal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants