Skip to content

Fix tower HTF user properties bug#1817

Merged
taylorbrown75 merged 1 commit into
patchfrom
mspt_userprops_btn
Jul 24, 2024
Merged

Fix tower HTF user properties bug#1817
taylorbrown75 merged 1 commit into
patchfrom
mspt_userprops_btn

Conversation

@taylorbrown75

Copy link
Copy Markdown
Collaborator

Description

There is a bug where HTF user properties 'edit' button is disabled when the user selects 'User-defined' on the Tower and Receiver tab for power tower. The UI indexing is off, the edit button is enabled when users select the 3rd option in the HTF type drop down, rather than the 4th.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@taylorbrown75 taylorbrown75 added the csp concentrating solar power label Jul 22, 2024
@taylorbrown75 taylorbrown75 self-assigned this Jul 22, 2024
@cpaulgilman cpaulgilman self-requested a review July 24, 2024 17:11
@cpaulgilman cpaulgilman added this to the 2023 Release Patch 2 milestone Jul 24, 2024

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I tested by importing custom fluid properties for a default MSPT / Single Owner case and running a simulation.

@cpaulgilman cpaulgilman added UI User interface issue that applies across performance and financial models added to release notes PR and/or issue has been added to release notes for a public release labels Jul 24, 2024
@taylorbrown75 taylorbrown75 merged commit 1555ed5 into patch Jul 24, 2024
@cpaulgilman cpaulgilman deleted the mspt_userprops_btn branch July 24, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release csp concentrating solar power UI User interface issue that applies across performance and financial models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants