Skip to content

Address SAM issue #1362#1753

Merged
sjanzou merged 3 commits into
patchfrom
SAM_1362
Apr 9, 2024
Merged

Address SAM issue #1362#1753
sjanzou merged 3 commits into
patchfrom
SAM_1362

Conversation

@sjanzou

@sjanzou sjanzou commented Apr 8, 2024

Copy link
Copy Markdown
Collaborator

#1362

To test check out SAM_1362 branch of SAM and patch branches of other repos and build.

  1. Create a PV/No financial case
  2. Click PV Uncertainty at bottom left
  3. run simulation
  4. click checkboxes to enable and disable the uncertainty sources
  5. Save and load
  6. Load project files from previous versions

image

@sjanzou sjanzou self-assigned this Apr 8, 2024
@sjanzou sjanzou linked an issue Apr 8, 2024 that may be closed by this pull request
@sjanzou sjanzou added this to the 2023 Release Patch 2 milestone Apr 8, 2024

@mjprilliman mjprilliman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything worked well when I tested this. Thanks for the addition!

@cpaulgilman

Copy link
Copy Markdown
Collaborator

One small nit to pick: If you clear all the check boxes, you get an LHS error. Might be better to generate a UI error like "Uncertainty simulations require at least one distribution."

image

@sjanzou

sjanzou commented Apr 8, 2024

Copy link
Copy Markdown
Collaborator Author

Uncertainty simulations require at least one distribution.

Thanks for nit-picking ;-). Updated to display message:
image

@sjanzou sjanzou merged commit f8b5c37 into patch Apr 9, 2024
@sjanzou sjanzou deleted the SAM_1362 branch April 9, 2024 00:24
@cpaulgilman cpaulgilman added added to release notes PR and/or issue has been added to release notes for a public release UI User interface issue that applies across performance and financial models labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release UI User interface issue that applies across performance and financial models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable or zero-out uncertainty variables

3 participants