Skip to content

Fix PDF report for battery dispatch#1750

Merged
cpaulgilman merged 1 commit into
patchfrom
pdf-report-batt-dispatch
Apr 4, 2024
Merged

Fix PDF report for battery dispatch#1750
cpaulgilman merged 1 commit into
patchfrom
pdf-report-batt-dispatch

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Add category for new "Self Consumption" option.

Add "Not Defined" category to avoid errors in future versions if we add dispatch options and forget to update the report template.

Fixes #1748

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Add category for new "Self Consumption" option.

Add "Not Defined" category to avoid errors in future versions if we add dispatch options and forget to update the report template.
@cpaulgilman cpaulgilman added bug UI User interface issue that applies across performance and financial models labels Apr 2, 2024
@cpaulgilman cpaulgilman added this to the 2023 Release Patch 2 milestone Apr 2, 2024
@cpaulgilman cpaulgilman requested a review from mjprilliman April 2, 2024 20:54
@cpaulgilman cpaulgilman self-assigned this Apr 2, 2024
@cpaulgilman cpaulgilman merged commit 695a9d0 into patch Apr 4, 2024
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug UI User interface issue that applies across performance and financial models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PDF report doesn't work for battery self-consumption battery dispatch option

2 participants