Skip to content

Fix adjust_periods upgrade for PV#1749

Merged
cpaulgilman merged 1 commit into
patchfrom
fix-pv-adjust-upgrade-script
Apr 4, 2024
Merged

Fix adjust_periods upgrade for PV#1749
cpaulgilman merged 1 commit into
patchfrom
fix-pv-adjust-upgrade-script

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

Fix version upgrade script to handle converting to adjust_periods from SAM 2022.11.21 and older when error message is triggered by incorrect number of columns.

Fixes #1611

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman added this to the 2023 Release Patch 2 milestone Apr 2, 2024
@cpaulgilman cpaulgilman self-assigned this Apr 2, 2024
@cpaulgilman cpaulgilman merged commit 2d1e600 into patch Apr 4, 2024
@cpaulgilman cpaulgilman added bug added to release notes PR and/or issue has been added to release notes for a public release labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrading "adjust" variable doesn't work

3 participants