Skip to content

Update Advanced NSRDB Downloads for latest NSRDB#1746

Merged
cpaulgilman merged 4 commits into
patchfrom
advanced_nsrdb
Apr 4, 2024
Merged

Update Advanced NSRDB Downloads for latest NSRDB#1746
cpaulgilman merged 4 commits into
patchfrom
advanced_nsrdb

Conversation

@cpaulgilman

@cpaulgilman cpaulgilman commented Mar 21, 2024

Copy link
Copy Markdown
Collaborator

Advanced NSRDB Downloads should now work properly for all NSRDB datasets.

  • Download all attributes (DNI, GHI, temperature, etc.) provided by NSRDB instead of selecting ones used by SAM. This increases file size (especially for PSM V3.2.2 that has several attributes SAM does not need like ghuv-280-400) but reduces maintenance requirements because we no longer need to update attribute lists in SAM as NSRDB is updated.

  • Add check boxes for 15- and 10-minute data provided by some endpoints. Automatically enable/disable checkboxes based on 'interval' and 'year' information in Solar Data Query response instead of based on dataset name.

Requires building SAM-private to test:

  1. Create a solar case (financial model not required).
  2. On Solar Resource page, click Advanced Download.
  3. For the location, try as many lat/lon and location names as possible, and click all checkboxes and buttons to test for functionality and possible errors.
  4. Click OK for at least some locations to download and verify weather files work.

The following is a list of locations to test most, if not all of the NSRDB endpoints:

Anchorage, Alaska
Manila, Philippines
Fuzhou, China
Hanoi, Vietnam
Baoshan, China
Lucknow, India
Jaipur, India
Ghardaia, Algeria
Arrecife, Canarias
Calheta, Azores
Mindelo, Cape Verde
Santo Domingo, Dominican Republic
Kauapushishkat, Canada
Wollaston Lake, Canada
Chignik, Alaska
Rochester, New York
Crawford, Nebraska
Kaunakakai, Hawaii
Puuwai, Hawaii
London, Kiribati
Rapa Iti, French Polynesia
Auala, Samoa
Alice Springs, Australia
Dunedin, New Zealand
Manaus, Brazil
Puerto Santa Cruz, Argentina
Lubumbashi, Democratic Republic of Congo

Fixes #1534

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman added bug UI User interface issue that applies across performance and financial models labels Mar 21, 2024
@cpaulgilman cpaulgilman added this to the 2023 Release Patch 2 milestone Mar 21, 2024
@cpaulgilman cpaulgilman self-assigned this Mar 21, 2024
@brtietz

brtietz commented Mar 22, 2024

Copy link
Copy Markdown
Collaborator

Is the return value of no weather files for Anchorage expected?

image

Looking at the NSRDB viewer, locations north of 60 aren't included. Chignik, Alaska works.

@cpaulgilman

cpaulgilman commented Apr 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@brtietz The NSRDB does not have data for locations higher than 60 degrees North latitude:

image

Chignik is at about 56 degrees N, and Anchorage is at about 61 degrees N.

@cpaulgilman cpaulgilman changed the title Upldate Advanced NSRDB Downloads for latest NSRDB Update Advanced NSRDB Downloads for latest NSRDB Apr 3, 2024
sjanzou
sjanzou approved these changes Apr 4, 2024
View reviewed changes

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit picking because I have been developing and UI for another project - should all of the filtering controls and OK button be disabled until the list box has some entries (note this has never been the case and is probably another issue)
image

Nice message for the middle of the ocean
image
but does not clear results (shown from previous search and inconsistent with Location - again another issue):
image

For this issue - I have found all working and simulating
image

Nice message at end of long download
image

64 degrees north
image

Unicode working:
image

Shetland Islands (maybe north of 60 deg working...
image

@mjprilliman mjprilliman removed their request for review April 4, 2024 14:48
@cpaulgilman

cpaulgilman commented Apr 4, 2024

Copy link
Copy Markdown
Collaborator Author

Shetland Islands (maybe north of 60 deg working...

Interesting case: Geocode API returns 60.187,-1.429. Nearest NSRDB grid cell center is at 59.97,-1.42, so it falls within the NSRDB coverage area with Lat < 60.

@cpaulgilman
Merge branch 'patch' into advanced_nsrdb
de2bf5d
@cpaulgilman
Address #1746 review by @sjanzou
a859d94 
* Reset widgets when Advanced NSRDB Window opens and when user clicks **Find**.
* Enable appropriate widgets after files are returned from NSRDB.
* Fix internal Debug error about `SetFirstItem()`
* Clean up comments
@cpaulgilman

cpaulgilman commented Apr 4, 2024

Copy link
Copy Markdown
Collaborator Author

@sjanzou Thank for nit picking! Please review my latest commit that should fix these issue.

@cpaulgilman cpaulgilman requested a review from sjanzou April 4, 2024 17:08
brtietz
brtietz approved these changes Apr 4, 2024
View reviewed changes

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good! It looks like this also works for the meteosat data as well, I was able to get weather files for London, England and Paris with the code on this branch.

@cpaulgilman cpaulgilman merged commit 3627f79 into patch Apr 4, 2024
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brtietz brtietz brtietz approved these changes

@sjanzou sjanzou Awaiting requested review from sjanzou

Assignees

@cpaulgilman cpaulgilman

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug UI User interface issue that applies across performance and financial models

Projects

None yet

Milestone

2023 Release Patch 2

Development

Successfully merging this pull request may close these issues.

Advanced NSRDB download updates

3 participants

@cpaulgilman @brtietz @sjanzou