Skip to content

Update PV land area calcs#1697

Merged
mjprilliman merged 2 commits into
patchfrom
land-area-update
Feb 26, 2024
Merged

Update PV land area calcs#1697
mjprilliman merged 2 commits into
patchfrom
land-area-update

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

-Update land area calculations to use the total module area rather than the projection
-Allows calculation to be the same across shade modes
-Add PVWatts technology checks to land area calculator

Fixes #1682

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added pv pvsam1, pvwatts, hcpv requires help revision Requires a Help revision before releasing public version labels Feb 13, 2024
@mjprilliman mjprilliman added this to the 2023 Release Patch 1 milestone Feb 13, 2024
@mjprilliman mjprilliman self-assigned this Feb 13, 2024
@cpaulgilman cpaulgilman added UI User interface issue that applies across performance and financial models and removed UI User interface issue that applies across performance and financial models labels Feb 15, 2024
@mjprilliman mjprilliman merged commit adc23a7 into patch Feb 26, 2024
@mjprilliman mjprilliman deleted the land-area-update branch February 26, 2024 17:11
@cpaulgilman cpaulgilman added added to release notes PR and/or issue has been added to release notes for a public release and removed requires help revision Requires a Help revision before releasing public version labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release pv pvsam1, pvwatts, hcpv

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix PV land area calculations

2 participants