Skip to content

Fix PV shading diagrams#1696

Merged
cpaulgilman merged 1 commit into
patchfrom
ui-pv-shading-images
Feb 13, 2024
Merged

Fix PV shading diagrams#1696
cpaulgilman merged 1 commit into
patchfrom
ui-pv-shading-images

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Fix diagram on PV Shading and Layout page to show example of both portrait and layout orientation.

Fix layout messages to avoid overlapping text when multiple subarrays have layout issues.

Fixes #1688

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Fix formatting of shading layout messages
@cpaulgilman cpaulgilman added the UI User interface issue that applies across performance and financial models label Feb 13, 2024
@cpaulgilman cpaulgilman added this to the 2023 Release Patch 1 milestone Feb 13, 2024
@cpaulgilman cpaulgilman self-assigned this Feb 13, 2024

@mjprilliman mjprilliman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you wanted to update the images for the help system as well?

image

@cpaulgilman cpaulgilman added the requires help revision Requires a Help revision before releasing public version label Feb 13, 2024
@cpaulgilman cpaulgilman merged commit 6ee3366 into patch Feb 13, 2024
@cpaulgilman cpaulgilman deleted the ui-pv-shading-images branch February 13, 2024 22:11
@cpaulgilman cpaulgilman added added to release notes PR and/or issue has been added to release notes for a public release and removed requires help revision Requires a Help revision before releasing public version labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release UI User interface issue that applies across performance and financial models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PV Module orientation diagrams on Shading and Layout page duplicated

2 participants