Fix solar resource download geocoding issues#1692
Conversation
If user enters a string that appears to be a lat/lon pair in decimal degrees, submit that directly to the NSRDB API instead of attempting to geocode it.
This shows lat/lon value that is submitted to NSRDB API to help with troubleshooting geocoding issues.
According to MapQuest API documentation: latLng "Returns the latitude/longitude for routing and is the nearest point on a road for the entrance." displayLatLng "A lat/lng pair that can be helpful when showing this address as a Point of Interest." https://developer.mapquest.com/documentation/geocoding-api/address/get
|
Testing this requires building SAM-private. to get that to work, I had to modify the SAM-private CMakeLists.txt to comment out the SDK tool settings:
To run the private version from Visual Studio 2022:
|
sjanzou
left a comment
There was a problem hiding this comment.
For me, SAM-private built without issue using the unmodified CMakeLists.txt in the patch branch.
The more detailed feedback is great:
However, -39,105 creates a callback error:
* Add support for all available international datasets from NSRDB, including TMYs where available (psm3-2-2-tmy, himawari-tmy, suny-india-tmy) * For locations with data available from multiple end points prioritize in order: psm3-2-2, himawari, msg-iodc, suny-india * Fix callback error when lat/lon for unavailable location submitted
|
@sjanzou ea6c555 should resolve the callback issue and also adds support for downloading international data. Here's a CSV file with a list of location names and lat/lon pairs for places around the world and available NSRDB datasets and and LK script that creates it that might be helpful for testing: nsrdb-endpoints.zip |
sjanzou
left a comment
There was a problem hiding this comment.
Working for all valid lat/lon tested and for values for which there is no NSRDB data, returns all information we have; e.g.
Pull Request Template
Description
NSRDB downloads from Solar Resource input page was submitting user input string to
geocode()function, assuming that the geocoding API parses the string to determine if it is a street address, location, name, or lat/lon pair. However,geocode()function sends input string to the MapQuest Geocode Address API, which requires a street address or location name as input: https://developer.mapquest.com/documentation/geocoding-api/address/get/. The private NREL developer geocoding API is a wrapper for the MapQuest API, and is not designed to take lat/lon as input.Items fixed:
geocode()function documentation to remove lat/lon as input option.Note related issues that will be fixed in separate pull requests:
Fixes #1526
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.