Add DC loss factor checks to PV, PV + battery report template#1690
Merged
Conversation
cpaulgilman
requested changes
Feb 6, 2024
cpaulgilman
approved these changes
Feb 26, 2024
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
This looks good for report generator. Thanks for fixing.
There is a problem with PV-battery availability losses that I will create a separate issue for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
-Add line for DC constant curtailment/availability loss factor
-Add checks for DC hourly/period losses in table row
-Updated for PV, PV + battery templates
Fixes #1588
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.