Skip to content

Update ShadeFactor widget to pass values to separated variables#1593

Merged
sjanzou merged 2 commits into
developfrom
shade-factors-fix
Nov 19, 2023
Merged

Update ShadeFactor widget to pass values to separated variables#1593
sjanzou merged 2 commits into
developfrom
shade-factors-fix

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

-Update ShadeFactorCtrl to work like LossAdjustmentCtrl
-Pass prepend of name ('shading' or 'subarrayx_shading') to table values

Fixes #1578

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added this to the SAM Fall 2023 Release milestone Nov 17, 2023
@mjprilliman mjprilliman self-assigned this Nov 17, 2023
@janinefreeman janinefreeman removed the request for review from sjanzou November 17, 2023 23:50
@sjanzou sjanzou merged commit 7cac6d7 into develop Nov 19, 2023
@sjanzou sjanzou deleted the shade-factors-fix branch November 19, 2023 08:21
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ShadingFactors aren't applying correctly

4 participants