Skip to content

Marine, Geothermal UI fixes#1591

Merged
mjprilliman merged 22 commits into
developfrom
marine-geothermal-fixes
Nov 28, 2023
Merged

Marine, Geothermal UI fixes#1591
mjprilliman merged 22 commits into
developfrom
marine-geothermal-fixes

Conversation

@mjprilliman

@mjprilliman mjprilliman commented Nov 17, 2023

Copy link
Copy Markdown
Collaborator

Description

-Mac UI overlap issues addressed
-Fix show/hide issues with marine costs
-Change units of geothermal reservoir_pressure_change variable
-Update wave, tidal resource library columns and example files

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

mjprilliman and others added 14 commits November 15, 2023 08:57
@mjprilliman
Mac form fixes, UI fixes for marine, geothermal, updates library reading
1bb080f 
for tidal
@mjprilliman
Update defaults
750d44b
@cpaulgilman
UI layout fixes
565dcc6
@cpaulgilman
Fix #1576 PVWatts battery above advanced inputs
d4838c1
@mjprilliman
Merge branch 'develop' into marine-geothermal-fixes
d0fdb1f
@cpaulgilman
Fix text too long for config and navigation tree
89f24fc 
* Change font size from 13 to 12
* Hard code navigation tree width (needs testing on Mac and Linux)
@cpaulgilman
Navigation menu width for Linux
86e45ea
@cpaulgilman
UI form fixes for Linux
9454015
@cpaulgilman
Hard code tech width in configuration chooser
956327d
@cpaulgilman
Merge branch 'ui-mac-fixes' of https://github.com/NREL/SAM into ui-ma…
4b13309 
…c-fixes
@cpaulgilman
Merge branch 'develop' into ui-mac-fixes
8c00740
@mjprilliman
Merge branch 'develop' into marine-geothermal-fixes
14cf809
@mjprilliman
Update wave time series library, fix UI alignment
9905a69
@mjprilliman
Merge branch 'develop' into marine-geothermal-fixes
f71dd38
@mjprilliman mjprilliman added this to the SAM Fall 2023 Release milestone Nov 17, 2023
@mjprilliman mjprilliman self-assigned this Nov 17, 2023
@janinefreeman janinefreeman self-requested a review November 17, 2023 16:46
@janinefreeman

janinefreeman commented Nov 17, 2023

Copy link
Copy Markdown
Collaborator

@cpaulgilman I can check everything in this PR except the Mac forms.

janinefreeman
janinefreeman approved these changes Nov 17, 2023
View reviewed changes

@janinefreeman janinefreeman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed everything except Mac/Linux spacing, all looks good with latest commit

@cpaulgilman

cpaulgilman commented Nov 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Reviewed everything except Mac/Linux spacing, all looks good with latest commit

@janinefreeman Can you check this again after I merged in ui-mac-fixes? I'm getting a mimo error for Geothermal on a Mac -- do you see that in Windows?

@mjprilliman

mjprilliman commented Nov 17, 2023

Copy link
Copy Markdown
Collaborator Author

Reviewed everything except Mac/Linux spacing, all looks good with latest commit

@janinefreeman Can you check this again after I merged in ui-mac-fixes? I'm getting a mimo error for Geothermal on a Mac -- do you see that in Windows?

Just for a sanity check did you have the same branch name checked out in ssc?

@cpaulgilman

cpaulgilman commented Nov 17, 2023

Copy link
Copy Markdown
Collaborator

Reviewed everything except Mac/Linux spacing, all looks good with latest commit

@janinefreeman Can you check this again after I merged in ui-mac-fixes? I'm getting a mimo error for Geothermal on a Mac -- do you see that in Windows?

Just for a sanity check did you have the same branch name checked out in ssc?

Ah, missed that.

@mjprilliman mjprilliman merged commit 25c9af7 into develop Nov 28, 2023
@mjprilliman mjprilliman deleted the marine-geothermal-fixes branch November 28, 2023 20:31
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 30, 2023
@johnjasa johnjasa mentioned this pull request Mar 28, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janinefreeman janinefreeman janinefreeman approved these changes

@cpaulgilman cpaulgilman cpaulgilman approved these changes

Assignees

@mjprilliman mjprilliman

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Milestone

SAM Fall 2023 Release

Development

Successfully merging this pull request may close these issues.

3 participants

@mjprilliman @janinefreeman @cpaulgilman