Skip to content

Report template updates#1579

Merged
mjprilliman merged 2 commits into
developfrom
report-templates
Nov 17, 2023
Merged

Report template updates#1579
mjprilliman merged 2 commits into
developfrom
report-templates

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Description

-Update adjust and shading variables for new separate variables
-Update tidal resource to not print tidal resource probability for time series option

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added this to the SAM Fall 2023 Release milestone Nov 16, 2023
@mjprilliman mjprilliman self-assigned this Nov 16, 2023

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Detailed PV degradation is being reported as zero in report. I don't think the report generator was ever updated for DC degradation (works fine for PVWatts). Not sure if you want to fix that here or create another issue.

@mjprilliman mjprilliman merged commit 79cd414 into develop Nov 17, 2023
@mjprilliman mjprilliman deleted the report-templates branch November 17, 2023 15:08
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants