Skip to content

Update NSRDB in UI callback to PSM V3.2.2#1559

Merged
cpaulgilman merged 3 commits into
developfrom
nsrdb-v3-to-v3-2-2
Nov 10, 2023
Merged

Update NSRDB in UI callback to PSM V3.2.2#1559
cpaulgilman merged 3 commits into
developfrom
nsrdb-v3-to-v3-2-2

Conversation

@cpaulgilman

@cpaulgilman cpaulgilman commented Nov 9, 2023

Copy link
Copy Markdown
Collaborator

Update UI callback script on Solar Resource Data form to download data from NSRDB PSM V3.2.2 and PSM V3.2.2-tmy endpoints.

Requires building SAM-private to test NSRDB downloads, or setting keys in private.h.

To test, create a solar case, and choose the "Choose year" option on the Solar Resource page. List should show files for years up to 2022.

Fixes #1557

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman added this to the SAM Fall 2023 Release milestone Nov 9, 2023
@cpaulgilman cpaulgilman requested a review from sjanzou November 9, 2023 23:32
@cpaulgilman cpaulgilman self-assigned this Nov 9, 2023
@sjanzou

sjanzou commented Nov 10, 2023

Copy link
Copy Markdown
Collaborator

Github Actions failing due to new variable:
image

All 167 default configurations running on Windows

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solar resource page changes look good.
Defaults updated to include new variable t_wet.
All 167 defaults running on Windows

@cpaulgilman cpaulgilman merged commit 78f8466 into develop Nov 10, 2023
@cpaulgilman cpaulgilman deleted the nsrdb-v3-to-v3-2-2 branch November 10, 2023 17:36
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update NSRDB downloads to PSM v3-2-2

2 participants