Skip to content

Clearance height warnings for bifacial systems#1544

Merged
mjprilliman merged 7 commits into
developfrom
clearance-height-warnings
Nov 10, 2023
Merged

Clearance height warnings for bifacial systems#1544
mjprilliman merged 7 commits into
developfrom
clearance-height-warnings

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Description

-Add red text warning for when the fixed tilt, tracker rotation limit, or monthly tilt could cause ground interference with the specified bifacial ground clearance height

Fixes #1088

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added this to the SAM Fall 2023 Release milestone Nov 2, 2023
@mjprilliman mjprilliman self-assigned this Nov 2, 2023
@mjprilliman

Copy link
Copy Markdown
Collaborator Author

@cpaulgilman Before I move this to other module pages can you test this to see if you like the functionality. I'd prefer this over msgbox warnings as they could pop up often in system design. This won't have any effect on calculations at the moment.

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting a callback error when I enable bifacial for the default Detailed PV / Single Owner case:

Could not evaluate callback function:cec_is_bifacial->on_change
[94]: reference to unassigned variable:check_clearance_height
[94]: error: _s
[94]: eval error in statement list

@mjprilliman

Copy link
Copy Markdown
Collaborator Author

I'm getting a callback error when I enable bifacial for the default Detailed PV / Single Owner case:

Could not evaluate callback function:cec_is_bifacial->on_change
[94]: reference to unassigned variable:check_clearance_height
[94]: error: _s
[94]: eval error in statement list

@cpaulgilman this should be cleaned up now but no rush on the review.

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The callback issue is fixed -- thanks. Let me know when this is ready for a full review.

@mjprilliman

Copy link
Copy Markdown
Collaborator Author

The callback issue is fixed -- thanks. Let me know when this is ready for a full review.

I believe it's ready for a full review, I will let you come up with better language for the message. I am happy to apply that language to all the pages once you have it.

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Looks good for 1-axis tracking.

A couple of questions:

  1. Should there be a check for fixed arrays?
  2. Should there also be an SSC check on ground clearance? Right now, it is possible to enter negative values and zero for ground clearance, and SSC is not checking for insufficient clearance.

@mjprilliman

Copy link
Copy Markdown
Collaborator Author

Looks good for 1-axis tracking.

A couple of questions:

  1. Should there be a check for fixed arrays?
  2. Should there also be an SSC check on ground clearance? Right now, it is possible to enter negative values and zero for ground clearance, and SSC is not checking for insufficient clearance.
  1. For fixed arrays that distance is the distance between the ground and the bottom edge of the module so it would not apply here.
  2. I can add SSC checks in the var table and potentially SSC notices, the actual calculations are not currently accounting ground interference.

@mjprilliman mjprilliman merged commit 48a9f30 into develop Nov 10, 2023
@mjprilliman mjprilliman deleted the clearance-height-warnings branch November 10, 2023 19:22
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ground interference occuring for 1-axis bifacial

2 participants