Geothermal SAM updates#1524
Merged
Merged
Conversation
Update deprecated Ubuntu workflow
Avoid getting `inverter_count` value for HCPV. Add message about multiple MPPT not available for HCPV to UI message.
* Fix critical load checks * New `load_error_messages()` UI callback function to display error when critical load and electric load time steps do not match and to check critical load multiple of 8760 * Move `msgbox()` from Electric Load Equations to UI callback function because equations evaluated when case loads, so message does not appear when variables change on Grid Outage and Electric Load page * Fix data checks in load mimo function
* Fix loss diagram Loss labels cut off at right Baseline labels overlap border at bottom of diagram * Adjust text width * Fix loss diagram label
Collaborator
Author
|
Will run the test script update this evening. I'm hoping to get this to a point to include in the next beta, will make new issues and PRs of outstanding issues to address. |
cpaulgilman
reviewed
Oct 27, 2023
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Tooltips look great! For other models we've used the tooltips JSON file to make it easier to review and edit tooltips in one place: https://github.com/NREL/SAM/blob/develop/deploy/runtime/help/tooltips.json.
I found a couple of overlapping UI widgets:
cpaulgilman
approved these changes
Oct 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
-Add tool tips to important input variables
-Add inputs for more precise well count calculations
-Add option for wet bulb temperature from weather file
-Closes #1480
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.