Pull Request Template

Description

Move module dimensions inputs from Shading and Layout page. For older versions of SAM, aspect ratio was only used as input to shading model, but now module dimensions are used for shading, land area, and heat transfer cell temp calculations, so makes more sense on the Module page.

Add UI callback code to calculate aspect ratio for CEC module model with library when length and width is available in library.

Also fixes some issues with opening .sam files created in SAM 2022.11.21:

• Enforces modules per string and strings in parallel > 0 requirement for disabled subarrays. (Default values are 0 for SAM 2022.11.21, so causes simulation error if not changed in versions.lk.)
• Fixes converting adjust:periods to adjust_periods when old value has wrong number of columns.

Fixes #245
Fixes #1518

SAM 2022.11.21 file with a case for each module model for testing: all-module-models-sam-2022-11-21.zip

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have checked my code and corrected any misspellings