New Icons and Logo#1514
Merged
Merged
Conversation
sjanzou
reviewed
Oct 24, 2023
Collaborator
There was a problem hiding this comment.
SAM open source has new icon in title bar and old icon in Explorer
SAM-private has new icon in title bar and explorer
Both have new icon in taskbar tray...
MacOS - open source - both Finder and the Dock have the new icon
Beta version message has old icon (MacOS)
MacOS build from SAM-private has old icon on dock and new icon on welcome page and old icon in Finder
I updated SAM.icns in the SAM-private/build_osx folder in the sam-log branch of SAM-private and the dock, finder, and beta message all have the new icon
Is that the desired functionality?
sjanzou
approved these changes
Oct 25, 2023
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Works on MacOS and Windows with SAM-private pull request https://github.com/NREL/SAM-private/pull/95
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New icons for Windows and macOS.
Fixes #1432