Skip to content

rename price signals dispatch to retail rate#1495

Merged
brtietz merged 3 commits into
developfrom
ssc_1123_price_signals_to_retail_rate_naming
Oct 16, 2023
Merged

rename price signals dispatch to retail rate#1495
brtietz merged 3 commits into
developfrom
ssc_1123_price_signals_to_retail_rate_naming

Conversation

@brtietz

@brtietz brtietz commented Oct 11, 2023

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

Renames price signals dispatch to retail rate dispatch

Fixes #1123

Companion SSC PR: NatLabRockies/ssc#1064

To test: ensure retail rates dispatch UI forms load and dispatch runs for PV+Battery, generic system battery and stand alone battery, as well as hybrids configurations (all BTM).

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@brtietz brtietz added battery requires help revision Requires a Help revision before releasing public version labels Oct 11, 2023
@brtietz brtietz added this to the SAM Fall 2023 Release milestone Oct 11, 2023
@brtietz brtietz requested a review from cpaulgilman October 11, 2023 21:44
@brtietz brtietz marked this pull request as draft October 12, 2023 21:05
@brtietz

brtietz commented Oct 12, 2023

Copy link
Copy Markdown
Collaborator Author

Convert to draft until I figure out why Ubuntu build is stuck at case 113

…ids, get self consumption working in a few more configurations
@brtietz brtietz marked this pull request as ready for review October 13, 2023 16:25
@brtietz

brtietz commented Oct 13, 2023

Copy link
Copy Markdown
Collaborator Author

The solution was additional changes to startup.lk for the fuel cell and hybrids configurations. Ready for review.

@brtietz brtietz merged commit 8bfe926 into develop Oct 16, 2023
@cpaulgilman cpaulgilman removed the requires help revision Requires a Help revision before releasing public version label Nov 10, 2023
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 30, 2023
@brtietz brtietz deleted the ssc_1123_price_signals_to_retail_rate_naming branch December 13, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release battery

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change Price Signals Dispatch to Utility Rate Dispatch

2 participants