Skip to content

Disable default type for LCOE Calculator and No Financial#1488

Merged
cpaulgilman merged 2 commits into
developfrom
SAM_1419-geothermal-load-default-type
Oct 25, 2023
Merged

Disable default type for LCOE Calculator and No Financial#1488
cpaulgilman merged 2 commits into
developfrom
SAM_1419-geothermal-load-default-type

Conversation

@cpaulgilman

@cpaulgilman cpaulgilman commented Oct 5, 2023

Copy link
Copy Markdown
Collaborator

Show message for LCOE Calculator and No Financial explaining that Default Type not available.

Fixes #1418

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman
Disable default type for LCOE Calculator and No Financial
0589f2d 
Show message for LCOE Calculator and No Financial explaining that Default Type not available.
@cpaulgilman cpaulgilman added the bug label Oct 5, 2023
@cpaulgilman cpaulgilman added this to the SAM Fall 2023 Release milestone Oct 5, 2023
@cpaulgilman cpaulgilman self-assigned this Oct 5, 2023
mjprilliman
mjprilliman reviewed Oct 5, 2023
View reviewed changes

@mjprilliman mjprilliman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good solution for No Financial. For LCOE Calculator I have it somewhere in a branch to tie in the cost pages with the LCOE calculator similar to marine so I think the default type would work at that point.

@cpaulgilman

cpaulgilman commented Oct 5, 2023

Copy link
Copy Markdown
Collaborator Author

I think this is a good solution for No Financial. For LCOE Calculator I have it somewhere in a branch to tie in the cost pages with the LCOE calculator similar to marine so I think the default type would work at that point.

Will that branch be part of the Fall 2023 release?

@mjprilliman

mjprilliman commented Oct 5, 2023

Copy link
Copy Markdown
Collaborator

I think this is a good solution for No Financial. For LCOE Calculator I have it somewhere in a branch to tie in the cost pages with the LCOE calculator similar to marine so I think the default type would work at that point.

Will that branch be part of the Fall 2023 release?

Yes I have been consolidating geothermal model changes into a single feature branch. I will up PR's hopefully soon with changes. I made placeholder issue #1480 for the release.

@cpaulgilman

cpaulgilman commented Oct 5, 2023

Copy link
Copy Markdown
Collaborator Author

I think this is a good solution for No Financial. For LCOE Calculator I have it somewhere in a branch to tie in the cost pages with the LCOE calculator similar to marine so I think the default type would work at that point.

Will that branch be part of the Fall 2023 release?

Yes I have been consolidating geothermal model changes into a single feature branch. I will up PR's hopefully soon with changes. I made placeholder issue #1480 for the release.

One of the variables required for the default type is analysis_period, which is not an input for the LCOE Calculator. (It is an input for the UI equations that calculate the FCR, but it is not required when the user provides the FCR as input.) How do you want to handle that case?

@mjprilliman

mjprilliman commented Oct 6, 2023

Copy link
Copy Markdown
Collaborator

I think this is a good solution for No Financial. For LCOE Calculator I have it somewhere in a branch to tie in the cost pages with the LCOE calculator similar to marine so I think the default type would work at that point.

Will that branch be part of the Fall 2023 release?

Yes I have been consolidating geothermal model changes into a single feature branch. I will up PR's hopefully soon with changes. I made placeholder issue #1480 for the release.

One of the variables required for the default type is analysis_period, which is not an input for the LCOE Calculator. (It is an input for the UI equations that calculate the FCR, but it is not required when the user provides the FCR as input.) How do you want to handle that case?

I'll have to come up with a plan for that case, it may be that analysis period is not a needed variable in the default editor. In the meantime I think it's probably to disable the default type for the LCOE calculator and I can revisit a change later.

@cpaulgilman cpaulgilman merged commit 500ac98 into develop Oct 25, 2023
@cpaulgilman cpaulgilman deleted the SAM_1419-geothermal-load-default-type branch October 25, 2023 00:26
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjprilliman mjprilliman mjprilliman approved these changes

Assignees

@cpaulgilman cpaulgilman

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug

Projects

None yet

Milestone

SAM Fall 2023 Release

Development

Successfully merging this pull request may close these issues.

Report PV outputs required for bifacial module efficiency

2 participants

@cpaulgilman @mjprilliman