Skip to content

Set adj losses to zero for pv+battery cases#1463

Merged
brtietz merged 9 commits into
developfrom
zero_out_availability_losses
Oct 11, 2023
Merged

Set adj losses to zero for pv+battery cases#1463
brtietz merged 9 commits into
developfrom
zero_out_availability_losses

Conversation

@brtietz

@brtietz brtietz commented Sep 25, 2023

Copy link
Copy Markdown
Collaborator

Merge into develop losses fix I used during the battery webinar. Emails/SAM meeting feedback confirmed these weren't intentional.

@brtietz brtietz added this to the SAM Fall 2023 Release milestone Sep 25, 2023
@brtietz brtietz requested a review from cpaulgilman September 25, 2023 21:30
@brtietz brtietz marked this pull request as draft September 25, 2023 22:05
@brtietz

brtietz commented Sep 25, 2023

Copy link
Copy Markdown
Collaborator Author

Changed to draft because I remembered that I need to re-run the test results for this type of change. Going to let #1462 go first, then I'll re-run the tests.

@brtietz brtietz marked this pull request as ready for review September 27, 2023 16:01

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for PV-battery configs.

All CSP and IPH configs have a adjust_constant = 4 by default except for:

MSPT, None
MSPT IPH, None
MSPT IPH, LCOH

Maybe set those to 4 to be consistent and then confirm with @tyneises and @taylorbrown75?

@tyneises

Copy link
Copy Markdown
Collaborator

Looks good for PV-battery configs.

All CSP and IPH configs have a adjust_constant = 4 by default except for:

MSPT, None MSPT IPH, None MSPT IPH, LCOH

Maybe set those to 4 to be consistent and then confirm with @tyneises and @taylorbrown75?

We ought to consider whether all IPH models should be something other than 4 considering they don't have a power block, but for now I think making everything 4 is a good plan

@brtietz brtietz merged commit a94a95a into develop Oct 11, 2023
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 30, 2023
@brtietz brtietz deleted the zero_out_availability_losses branch December 13, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants