Skip to content

PV subhourly clipping implementation#1447

Merged
mjprilliman merged 15 commits into
developfrom
pv-subhourly-clipping
Sep 15, 2023
Merged

PV subhourly clipping implementation#1447
mjprilliman merged 15 commits into
developfrom
pv-subhourly-clipping

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Description

-Adds UI checkbox for calculating subhourly clipping correction via Allen method
-Lookup matrix used for calculations not stored in UI, editing matrix SDK feature only
-Adds outputs for subhourly clipping losses, clearsky irradiance components
-Adds UI calculated variable for number of inverters needed for DC:AC ratio of 1 (needed for calculations)
-Adds item to PV loss diagram (todo check report template)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added enhancement pv pvsam1, pvwatts, hcpv labels Sep 13, 2023
@mjprilliman mjprilliman added this to the SAM Fall 2023 Release milestone Sep 13, 2023
@mjprilliman mjprilliman self-assigned this Sep 13, 2023

@janinefreeman janinefreeman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functions nicely in the UI! I don't notice a slowdown. Outputs look good, loss diagram seems to work well.

  • The label on the Losses page needs to be updated now that the matrix isn't in the UI anymore.
  • Would suggest updating the label for the "clipping potential" to be "subhourly clipping potential" to be consistent with other labels.
  • See other notes in review below

Comment thread deploy/runtime/defaults/Flat Plate PV_All Equity Partnership Flip.json Outdated
Comment thread deploy/runtime/defaults/Flat Plate PV_Commercial.json
Comment thread deploy/runtime/defaults/Flat Plate PV_Host Developer.json Outdated
Comment thread deploy/runtime/ui/PV Losses.json Outdated
Comment thread deploy/runtime/ui/PV Subhourly Clipping.json Outdated
Comment thread deploy/runtime/ui/PV System Design.json Outdated

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To consider after merging:

  • Consider a more informative name than "Subhourly clipping".
  • Add clear sky irradiance outputs to other solar models (CSP, solar water heating, etc.) ?

@mjprilliman mjprilliman merged commit 8fccdb4 into develop Sep 15, 2023
@mjprilliman mjprilliman deleted the pv-subhourly-clipping branch September 15, 2023 22:09
@cpaulgilman cpaulgilman added the requires help revision Requires a Help revision before releasing public version label Nov 11, 2023
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 30, 2023
@cpaulgilman cpaulgilman removed the requires help revision Requires a Help revision before releasing public version label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release enhancement pv pvsam1, pvwatts, hcpv

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants