PV subhourly clipping implementation#1447
Merged
Merged
Conversation
janinefreeman
requested changes
Sep 13, 2023
janinefreeman
left a comment
Collaborator
There was a problem hiding this comment.
Functions nicely in the UI! I don't notice a slowdown. Outputs look good, loss diagram seems to work well.
- The label on the Losses page needs to be updated now that the matrix isn't in the UI anymore.
- Would suggest updating the label for the "clipping potential" to be "subhourly clipping potential" to be consistent with other labels.
- See other notes in review below
cpaulgilman
approved these changes
Sep 14, 2023
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
To consider after merging:
- Consider a more informative name than "Subhourly clipping".
- Add clear sky irradiance outputs to other solar models (CSP, solar water heating, etc.) ?
janinefreeman
approved these changes
Sep 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
-Adds UI checkbox for calculating subhourly clipping correction via Allen method
-Lookup matrix used for calculations not stored in UI, editing matrix SDK feature only
-Adds outputs for subhourly clipping losses, clearsky irradiance components
-Adds UI calculated variable for number of inverters needed for DC:AC ratio of 1 (needed for calculations)
-Adds item to PV loss diagram (todo check report template)
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.