Skip to content

Add technology condition to critical load error message#1412

Merged
sjanzou merged 1 commit into
patchfrom
electric-load-callback-error
Jun 3, 2023
Merged

Add technology condition to critical load error message#1412
sjanzou merged 1 commit into
patchfrom
electric-load-callback-error

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Only check critical load time step if tech has grid outage inputs (is a battery storage tech).

Fixes #1411

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

- only check critical load time step if tech has grid outage inputs (is a battery storage tech)
@cpaulgilman cpaulgilman requested a review from brtietz June 1, 2023 16:00
@cpaulgilman cpaulgilman self-assigned this Jun 1, 2023
@cpaulgilman cpaulgilman added this to the 2022.11.21 Patch 3 milestone Jun 2, 2023
@cpaulgilman cpaulgilman requested a review from sjanzou June 2, 2023 19:56

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, thanks for fixing!

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with PV residential with and without storage with no callback error

@sjanzou sjanzou merged commit 45fba47 into patch Jun 3, 2023
@sjanzou sjanzou deleted the electric-load-callback-error branch June 3, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI callback error on Electric Load page

3 participants