Skip to content

Help installation cost#1347

Merged
cpaulgilman merged 4 commits into
patchfrom
help-installation-cost
Feb 8, 2023
Merged

Help installation cost#1347
cpaulgilman merged 4 commits into
patchfrom
help-installation-cost

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

Fix startup.lk script to use correct Help IDs for standalone battery installation costs page, and add new Help topic.

Also fix sales tax description in Help topic for all performance models.

To test, open a Standalone Battery case with any financial model, go to the Installation Costs page and press F1 or click Help and verify that the correct Help page opens.

Fixes #1334

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman added this to the 2022.11.21 Patch 1 milestone Feb 7, 2023
@cpaulgilman cpaulgilman self-assigned this Feb 7, 2023
@cpaulgilman cpaulgilman merged commit 662c69e into patch Feb 8, 2023
@cpaulgilman cpaulgilman deleted the help-installation-cost branch February 8, 2023 16:06
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standalone Battery installation cost page help topic missing

2 participants