Skip to content

Fix trough loop indicators#1329

Merged
Matthew-Boyd merged 2 commits into
patchfrom
fix-trough-loop-indicators
Jan 26, 2023
Merged

Fix trough loop indicators#1329
Matthew-Boyd merged 2 commits into
patchfrom
fix-trough-loop-indicators

Conversation

@Matthew-Boyd

Copy link
Copy Markdown
Contributor

Problem:
The indicators on the "Collectors (SCAs)" and "Receivers (HCEs)" pages for the trough models:
Collector types in loop configuration: Cold - 1 - 1 - 1 - 1 - 1 - 1 - 1 - 1 - Hot
Receiver types in loop configuration: Cold - 1 - 1 - 1 - 1 - 1 - 1 - 1 - 1 - Hot

do not reflect the configuration of the Single Loop Configuration widget on the Solar Field page. The collector configurations appears to show in the receiver indicator and vice-versa.

Explanation:

  1. The UI widget starts the convention of SCA first at index 0 and HCE second at index 1, or [SCA, HCE]
  2. The Sca_info_array(), which is called by the UI and during verify() before the SSC model is run, flips the convention from [SCA, HCE] to [HCE, SCA]
  3. The SSC submodel that uses this parameter, csp_solver_trough_collector_receiver.cpp, uses the convention [HCE, SCA], so the flipping by Sca_info_array() is warranted.

The problem arises because the UI reuses Sca_info_array() when displaying the SCA and HCE indicators on the respective UI pages, respectively. Since Sca_info_array() flips the convention for the sake of the SSC submodel, the indicator should not have the same convention as the UI widget, it should be flipped. And this is what was likely the confusion when this was implemented.

Solution:
Flip the convention in the '$MIMO$ collectors in field' and 'receivers_in_field' Equations on the "Physical Trough Collector Header" and "Physical Trough Receiver Header" UI Forms.

Closes #1319

@Matthew-Boyd Matthew-Boyd added this to the 2022.11.21 Patch 1 milestone Jan 25, 2023
@Matthew-Boyd Matthew-Boyd self-assigned this Jan 25, 2023
@Matthew-Boyd Matthew-Boyd merged commit 2c145c3 into patch Jan 26, 2023
@Matthew-Boyd Matthew-Boyd deleted the fix-trough-loop-indicators branch January 26, 2023 05:07
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSP Physical Trough flips SCA and HCE labels

2 participants