Add PTES Design Point Dialog Widget#1318
Merged
Merged
Conversation
Patch to develop 22 12 02
…alpha from dialog
…ty to ptes dialog to pass input variables not shown to user
Update ptes design point to latest version of patch
…her than copy code
Update ptes-design-pt to latest patch version to prevent conflicts
…ius. Set text controls in SAM to fixed decimal. Change Dialog results text controls to blue. Increase size of design point button. Increase width of design point dialog.
Update ptes-design-pt to latest version of patch
This commit includes other Help revisions that will be overwritten later.
cpaulgilman
requested changes
Jan 13, 2023
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
This looks good. I added a placeholder Help topic for the PTES System Design window. We can work on Help content separately.
I noticed some odd characters in the input boxes -- not sure if this was introduced by your code or not. Could you look into that? See this screenshot:
These need revision before releasing.
cpaulgilman
approved these changes
Jan 13, 2023
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
I'm also seeing those characters in the Patch branch on one of my Windows computers but not the other, so I don't think it is an issue with this pull request.
tyneises
pushed a commit
that referenced
this pull request
Jan 19, 2023
api updates and include update for pull request #1318 to work in both SAM and SAM-private
Collaborator
|
Fixes #1317 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Related to issue 1317 https://github.com/NREL/SAM/issues/1317
Add a button to PTES to open a design point dialog to calculate unintuitive inputs (such as heat pump COP).
Does not affect any other project.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.