Skip to content

Fix wave resource choice callback#1304

Merged
mjprilliman merged 2 commits into
patchfrom
sam-1303-fix
Jan 10, 2023
Merged

Fix wave resource choice callback#1304
mjprilliman merged 2 commits into
patchfrom
sam-1303-fix

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

-Removes unused availability function when changing wave resource option

Fixes #1303

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added this to the 2022.11.21 Patch 1 milestone Dec 12, 2022
@mjprilliman mjprilliman requested a review from dguittet December 12, 2022 23:04
@mjprilliman mjprilliman self-assigned this Dec 12, 2022
@dguittet dguittet requested review from cpaulgilman and removed request for dguittet December 12, 2022 23:09

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This fixes the UI callback error.

@mjprilliman mjprilliman merged commit 6f8c013 into patch Jan 10, 2023
@mjprilliman mjprilliman deleted the sam-1303-fix branch January 10, 2023 20:27
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Marine energy resource choice callback error

2 participants