Skip to content

Utilize lookback months when applying lookback percent. #1237

Merged
brtietz merged 3 commits into
developfrom
improve_urdb_lookback_months
Nov 8, 2022
Merged

Utilize lookback months when applying lookback percent. #1237
brtietz merged 3 commits into
developfrom
improve_urdb_lookback_months

Conversation

@brtietz

@brtietz brtietz commented Nov 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

Utilize lookbackmonths from urdbv8, as per #760 (comment)

Release will include corresponding PySAM changes, as per NatLabRockies/pysam#116

Good rates to test with:

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@brtietz brtietz added this to the SAM Fall 2022 Release milestone Nov 6, 2022
@brtietz brtietz requested a review from cpaulgilman November 6, 2022 18:30
Correct default for lookback months: true ensures correct behavior wh…
7f18132 
…en not defined in rate download (applies to all months
@brtietz brtietz marked this pull request as draft November 7, 2022 17:36
@brtietz

brtietz commented Nov 7, 2022

Copy link
Copy Markdown
Collaborator Author

Converting to draft - the handling of ur_dc_billing_demand_periods could also be improved (ensure number of periods matches TOU table)

add code to ui to handle ur_dc_billing_demand_periods - ensure the nu…
6e40d29 
…mber of periods matches what's in the rate. Fix a bug where lookbackpercent of 1 wasn't getting parsed
@brtietz brtietz marked this pull request as ready for review November 7, 2022 19:49
@brtietz

brtietz commented Nov 7, 2022

Copy link
Copy Markdown
Collaborator Author

Converting to draft - the handling of ur_dc_billing_demand_periods could also be improved (ensure number of periods matches TOU table)

Fixed, along with another surprise bug.

cpaulgilman
cpaulgilman approved these changes Nov 8, 2022
View reviewed changes

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Looks good for these two test rates, and messages in UI are working correctly.

@brtietz brtietz merged commit 56317be into develop Nov 8, 2022
@brtietz brtietz deleted the improve_urdb_lookback_months branch November 18, 2022 16:34
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpaulgilman cpaulgilman cpaulgilman approved these changes

Assignees

No one assigned

Labels

added to release notes PR and/or issue has been added to release notes for a public release enhancement utility rate

Projects

None yet

Milestone

SAM Fall 2022 Release

Development

Successfully merging this pull request may close these issues.

2 participants

@brtietz @cpaulgilman