Skip to content

Land area acre/MWac input#1195

Merged
mjprilliman merged 5 commits into
developfrom
land_area_per_mw
Oct 21, 2022
Merged

Land area acre/MWac input#1195
mjprilliman merged 5 commits into
developfrom
land_area_per_mw

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Description

-Input to specify land area usage through acre/MWac input rather than module area calculation.
-Useful for some system developers and researchers
-Applies for PV, PVWatts ( w/ and w/o battery)

-Can be pushed to patch if needed

Fixes #1185

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added the pv pvsam1, pvwatts, hcpv label Oct 18, 2022
@mjprilliman mjprilliman added this to the SAM Fall 2022 Release milestone Oct 18, 2022
@mjprilliman mjprilliman self-assigned this Oct 18, 2022
@mjprilliman mjprilliman changed the title Default updates Land area acre/MWac input Oct 18, 2022
* Use radio buttons instead of check box to make choices clearer

* Add more white space to improve legibility

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. See my comment in #1185

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New radio buttons work great!

@mjprilliman mjprilliman merged commit 3e6b07a into develop Oct 21, 2022
@mjprilliman mjprilliman deleted the land_area_per_mw branch October 21, 2022 14:54
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release pv pvsam1, pvwatts, hcpv

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PV land area acre/MW input

3 participants