Set enable rules to slope tilt, terrain#1191
Merged
Merged
Conversation
cpaulgilman
approved these changes
Oct 18, 2022
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. I tested for different subarrays and combinations of tracking/self shading. This now behaves consistently with description in Help, so no need for Help revisions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
-Enable/disable terrain slope and azimuth angle inputs for subarrays based on track mode, backtrack, and shade mode for each subarray
-For documentation, rules are as follows:
Otherwise terrain inputs are disabled as they do not impact results.
Fixes #759
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.