Skip to content

Set enable rules to slope tilt, terrain#1191

Merged
mjprilliman merged 1 commit into
developfrom
terrain_slope_enable_rules
Oct 18, 2022
Merged

Set enable rules to slope tilt, terrain#1191
mjprilliman merged 1 commit into
developfrom
terrain_slope_enable_rules

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Description

-Enable/disable terrain slope and azimuth angle inputs for subarrays based on track mode, backtrack, and shade mode for each subarray
-For documentation, rules are as follows:

  1. Single axis tracking must be selected
  2. At least one of backtracking enabled and shade mode set to Linear must be true.
    Otherwise terrain inputs are disabled as they do not impact results.

Fixes #759

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added the pv pvsam1, pvwatts, hcpv label Oct 14, 2022
@mjprilliman mjprilliman added this to the SAM Fall 2022 Release milestone Oct 14, 2022
@mjprilliman mjprilliman self-assigned this Oct 14, 2022

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tested for different subarrays and combinations of tracking/self shading. This now behaves consistently with description in Help, so no need for Help revisions.

@mjprilliman mjprilliman merged commit 2545f43 into develop Oct 18, 2022
@mjprilliman mjprilliman deleted the terrain_slope_enable_rules branch October 18, 2022 16:17
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release pv pvsam1, pvwatts, hcpv

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvements to sloped terrain UI feature

2 participants