Skip to content

PV albedo fixes#1180

Merged
cpaulgilman merged 9 commits into
developfrom
pv-albedo-fix
Oct 20, 2022
Merged

PV albedo fixes#1180
cpaulgilman merged 9 commits into
developfrom
pv-albedo-fix

Conversation

@cpaulgilman

@cpaulgilman cpaulgilman commented Oct 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Pull Request Template

Goes with NatLabRockies/ssc#887

Description

  • Fix UI options for weather file albedo and input albedo.

  • Reorganize UI for new spatial albedo input options

Fixes #1081

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • [X ] This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • [X ] New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • [X ] I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman added this to the SAM Fall 2022 Release milestone Oct 11, 2022
@cpaulgilman cpaulgilman requested a review from sjanzou October 11, 2022 00:25
@cpaulgilman cpaulgilman mentioned this pull request Oct 11, 2022
Merged
sjanzou
sjanzou approved these changes Oct 11, 2022
View reviewed changes

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All options were workign for me!
image

Comment thread test_results_win64.csv Outdated
Standalone Battery,All Equity Partnership Flip,-8397703,86.5441,88.6283,;
Standalone Battery,Sale Leaseback,-8397703,86.3995,88.6283,;
ETES,Single Owner,-498870720,17.93,12.4508,;
ETES,Single Owner,-497823968,17.9392,12.4517,;

@sjanzou sjanzou Oct 11, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why these are changing? This is a SAM meeting agenda item

@cpaulgilman cpaulgilman Oct 11, 2022

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe recent changes in SSC without updates to test results? For example, NatLabRockies/ssc@5110e35.

@cpaulgilman cpaulgilman self-assigned this Oct 20, 2022
@cpaulgilman cpaulgilman merged commit 121fc63 into develop Oct 20, 2022
@cpaulgilman cpaulgilman deleted the pv-albedo-fix branch October 20, 2022 23:26
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjanzou sjanzou sjanzou approved these changes

Assignees

@cpaulgilman cpaulgilman

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Milestone

SAM Fall 2022 Release

Development

Successfully merging this pull request may close these issues.

"Invalid albedo value" error when no albedo values were provided

2 participants

@cpaulgilman @sjanzou