UI warning for negative tilt angles#1171
Merged
Merged
Conversation
cpaulgilman
requested changes
Oct 6, 2022
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Need to check conditions for tilt and azimuth error checks. For example:
SSC error exec fail(pvsamv1): Subarray 1 monthly tilt angles cannot be negative. when subarray1_track_mode is zero (fixed) and subarray1_monthly_tilt has a negative value for one of the months. See example in pv-monthly-tilt.zip.
SSC generates an error when track mode is 3 (azimuth axis tracking) and azimuth value is out of range even though azimuth is not used for this tracking option.
cpaulgilman
approved these changes
Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pop up message box when a negative tilt angle is entered. Combined with ssc var table prechecks NatLabRockies/ssc#885 should prevent negative tilt (and azimuth) angle definitions in SAM UI and SDK
Fixes #1087
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.