Skip to content

Add advanced bifacial PV and ground irradiance modeling#1152

Merged
Matthew-Boyd merged 23 commits into
NatLabRockies:developfrom
Matthew-Boyd:bifacial
Oct 6, 2022
Merged

Add advanced bifacial PV and ground irradiance modeling#1152
Matthew-Boyd merged 23 commits into
NatLabRockies:developfrom
Matthew-Boyd:bifacial

Conversation

@Matthew-Boyd

@Matthew-Boyd Matthew-Boyd commented Sep 18, 2022

Copy link
Copy Markdown
Contributor

Dependencies

/Matthew-Boyd/wex:bifacial
/Matthew-Boyd/ssc:bifacial

Description

Adds:

  • Irradiance loss factor differentiation
  • Rack shading loss
  • Intra-module electrical mismatch
  • Multi-albedo ground UI input
  • Temporospatial ground and rear irradiance output
  • Bifacial loss diagram additions

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there extra steps I need to take to get PV Albedo and Radiation.txt to work as a UI form? So far it is not being read properly. I will review in more detail when I can get the albedo UI form working.

Comment thread deploy/runtime/ui/PV Losses.txt
Comment thread deploy/runtime/ui/PV Losses.txt
Comment thread deploy/runtime/ui/PV Albedo and Radiation.txt

@mjprilliman mjprilliman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • UI is a bit confusing because when weather file albedo checkbox is checked, spatial albedo uses weather file albedo and UI inputs in matrix do not apply. Is this intended behavior?

  • Both spatial and single-value rear POA reported in outputs when spatial data is used. Single-value appears to be average of the spatial data. Will users get confused on this?
    image

  • Can these variable names indicate that they apply to the rear surface?
    image
    -I guess it makes sense to average bifacial electrical mismatch over all subarrays (all in one output)?

This is what I found so far in SAM, still working through ssc.

@Matthew-Boyd

Copy link
Copy Markdown
Contributor Author

UI is a bit confusing because when weather file albedo checkbox is checked, spatial albedo uses weather file albedo and UI inputs in matrix do not apply. Is this intended behavior?

It is the intended behavior. If "Use albedo from weather file if available" is checked, then the (single) albedo from the weather file is used if present, on a timestep-by-timestep basis. If an albedo value is missing in the weather file for a given timestep, then the spatial albedo is used (if "Use spatial monthly albedo values" is selected). I could see this functionality being useful for parametric studies of different years or locations that include differences in snow cover or crop harvesting (which can also occur at a sub-monthly fidelity). This will be explained in the help, but if this feature is too confusing, it can just be removed. @janinefreeman ? @cpaulgilman ?

@Matthew-Boyd

Copy link
Copy Markdown
Contributor Author

The Lifetime Hourly output for the rear irradiance after reflection is calculated from the corresponding Matrix output, but I wouldn't think it any more confusing than both the Single and Annual energy values that SAM has for some outputs. It's also a final irradiance value after losses, so it's a metric used more than others for comparison and analysis, for example to the front total irradiance after reflection. @cpaulgilman , what would you like with this?

@Matthew-Boyd

Copy link
Copy Markdown
Contributor Author

Can these variable names indicate that they apply to the rear surface?

Yes, done.

@Matthew-Boyd

Copy link
Copy Markdown
Contributor Author

This is what I found so far in SAM, still working through ssc.

Thank you @mjprilliman !

@mjprilliman

Copy link
Copy Markdown
Collaborator

The Lifetime Hourly output for the rear irradiance after reflection is calculated from the corresponding Matrix output, but I wouldn't think it any more confusing than both the Single and Annual energy values that SAM has for some outputs. It's also a final irradiance value after losses, so it's a metric used more than others for comparison and analysis, for example to the front total irradiance after reflection. @cpaulgilman , what would you like with this?

I'm fine with leaving the variables as they are just wanted to talk it through.

@cpaulgilman

Copy link
Copy Markdown
Collaborator

UI is a bit confusing because when weather file albedo checkbox is checked, spatial albedo uses weather file albedo and UI inputs in matrix do not apply. Is this intended behavior?

It is the intended behavior. If "Use albedo from weather file if available" is checked, then the (single) albedo from the weather file is used if present, on a timestep-by-timestep basis. If an albedo value is missing in the weather file for a given timestep, then the spatial albedo is used (if "Use spatial monthly albedo values" is selected). I could see this functionality being useful for parametric studies of different years or locations that include differences in snow cover or crop harvesting (which can also occur at a sub-monthly fidelity). This will be explained in the help, but if this feature is too confusing, it can just be removed. @janinefreeman ? @cpaulgilman ?

Let's keep this as is for now, and I will address this and some other albedo confusion in https://github.com/NREL/SAM/tree/pv-albedo-fix.

@cpaulgilman

Copy link
Copy Markdown
Collaborator

The Lifetime Hourly output for the rear irradiance after reflection is calculated from the corresponding Matrix output, but I wouldn't think it any more confusing than both the Single and Annual energy values that SAM has for some outputs. It's also a final irradiance value after losses, so it's a metric used more than others for comparison and analysis, for example to the front total irradiance after reflection. @cpaulgilman , what would you like with this?

I'm fine with leaving the variables as they are just wanted to talk it through.

Those "POA irradiance after..." outputs are confusing -- I think that should be addressed separately. (I think it might be clearer to show a single POA irradiance value and show the losses instead of a series of reduced POA values.)

@Matthew-Boyd Matthew-Boyd merged commit bf8276b into NatLabRockies:develop Oct 6, 2022
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release enhancement new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants