Skip to content

PV Uncertainty updates#1076

Merged
sjanzou merged 63 commits into
developfrom
PVUncertainty
Jun 27, 2022
Merged

PV Uncertainty updates#1076
sjanzou merged 63 commits into
developfrom
PVUncertainty

Conversation

@sjanzou

@sjanzou sjanzou commented Jun 20, 2022

Copy link
Copy Markdown
Collaborator

Please test and update tool tips as necessary
Goes with wex pull request 142
NatLabRockies/wex#142

sjanzou and others added 30 commits February 24, 2022 23:58

@mjprilliman mjprilliman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Is anyone else having trouble reading the distribution information?

image
Getting this gray box over the left side when a new case is building. Is that to update P50/P90 versus PV Uncertainty text?

-I'm not seeing the distribution selections persist on save, close, and re-open the case.

-How will this be handled in version upgrade? After making a file off of PVUncertainty and develop branches that file has issues being opened in patch 2.
image

@sjanzou

sjanzou commented Jun 21, 2022

Copy link
Copy Markdown
Collaborator Author

image Is anyone else having trouble reading the distribution information?

This issue is fixed in the latest commit for windows

image Getting this gray box over the left side when a new case is building. Is that to update P50/P90 versus PV Uncertainty text?

This is fixed and was due to an additional dialog being created with the PV Uncertainty form.

-I'm not seeing the distribution selections persist on save, close, and re-open the case.

Can you provide and example? Every case I tested and saved and reopened had all the distribution, weather file folder and pvalues changes saved and shown when reopened.

-How will this be handled in version upgrade? After making a file off of PVUncertainty and develop branches that file has issues being opened in patch 2. image

The project file is not backwards compatible since a new data structure (PVUncertaintyData) is stored in the project file. Old projects files can be read into the new structure due to the versioning in the Case::Read method. Olde versions of SAM cannot open the newly saved file since the case persistence version is now 7 (see case.cpp line 522).

Thanks for the detailed feedback!

@sjanzou sjanzou requested a review from mjprilliman June 21, 2022 10:52
@mjprilliman

Copy link
Copy Markdown
Collaborator

Can you provide and example? Every case I tested and saved and reopened had all the distribution, weather file folder and pvalues changes saved and shown when reopened.<

After more testing, changing distributions and then hitting the 'Run PV Uncertainty simulations' button causes the distributions to persist and close and re-open. Not hitting the 'Run' button after changing the distributions causes the distributions to revert to the previously run values on close and re-open. I think this behavior probably makes sense for the tool and should be left as it is but maybe just something to point out in Help.

@mjprilliman mjprilliman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good after the most recent commits.

@sjanzou

sjanzou commented Jun 21, 2022

Copy link
Copy Markdown
Collaborator Author

From 6/21/2022 meeting:

  1. Save distributions without running
  2. Enable user CDF
  3. do not clear graphs with p Value change
  4. remove vertical scrollbars in plot sizer

@sjanzou sjanzou merged commit f306e91 into develop Jun 27, 2022
@sjanzou sjanzou deleted the PVUncertainty branch June 27, 2022 11:23
@cpaulgilman cpaulgilman added this to the SAM Fall 2022 Release milestone Nov 18, 2022
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants