Skip to content

Fix CEC Modules#1067

Merged
sjanzou merged 2 commits into
patchfrom
fix-cec-modules
Jun 4, 2022
Merged

Fix CEC Modules#1067
sjanzou merged 2 commits into
patchfrom
fix-cec-modules

Conversation

@cpaulgilman

@cpaulgilman cpaulgilman commented Jun 3, 2022

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

Remove unicode characters from CEC Modules.csv to avoid EOF issue when loading file on SAM startup.

Updates #1057.

To be fixed in Fall 2022 release with #1066 and NatLabRockies/wex#141 after more thorough testing.

@cpaulgilman cpaulgilman added this to the 2021.12.02 Patch 2 milestone Jun 3, 2022
@cpaulgilman cpaulgilman requested a review from sjanzou June 3, 2022 14:22
@cpaulgilman cpaulgilman self-assigned this Jun 3, 2022

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will rerun the defaults and commit and push in another branch for the patch. Thanks Paul!

@cpaulgilman

Copy link
Copy Markdown
Collaborator Author

@sjanzou Thank you for running default test script. I didn't have time to do that before leaving this morning for the weekend.

@sjanzou sjanzou merged commit 3485d16 into patch Jun 4, 2022
@sjanzou sjanzou deleted the fix-cec-modules branch June 4, 2022 08:59
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants