Skip to content

Update CEC library files#1057

Merged
cpaulgilman merged 2 commits into
patchfrom
cec-libraries-may-2022
May 31, 2022
Merged

Update CEC library files#1057
cpaulgilman merged 2 commits into
patchfrom
cec-libraries-may-2022

Conversation

@cpaulgilman

@cpaulgilman cpaulgilman commented May 30, 2022

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

Update CEC module and inverter library from CEC Excel module file May 25, 2022 and inverter file May 23, 2022.

Fixes #989, Fixes #837

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman added this to the 2021.12.02 Patch 2 milestone May 30, 2022
@cpaulgilman cpaulgilman requested a review from sjanzou May 30, 2022 23:54
@cpaulgilman cpaulgilman self-assigned this May 30, 2022
sjanzou
sjanzou approved these changes May 31, 2022
View reviewed changes

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github actions were failing due to default results changes with updated libraries.
I reran the defaults and committed to this branch for Github Actions.
Thanks for updating the libraries!

@cpaulgilman

cpaulgilman commented May 31, 2022

Copy link
Copy Markdown
Collaborator Author

Github actions were failing due to default results changes with updated libraries. I reran the defaults and committed to this branch for Github Actions. Thanks for updating the libraries!

Thanks, Steve. I ran the test script to generate a new test_results_win64.csv file, but GitHub did not identify it as a changed file so I assumed the library updates did not change the default results.

@cpaulgilman cpaulgilman merged commit 279ffcf into patch May 31, 2022
@cpaulgilman cpaulgilman deleted the cec-libraries-may-2022 branch May 31, 2022 15:59
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Jun 2, 2022
@cpaulgilman cpaulgilman mentioned this pull request Jun 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjanzou sjanzou sjanzou approved these changes

Assignees

@cpaulgilman cpaulgilman

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Milestone

2021.12.02 Patch 2

Development

Successfully merging this pull request may close these issues.

CEC PV module file has a duplicate entry Update CEC module and inverter libraries for SAM 2021.12.02

2 participants

@cpaulgilman @sjanzou