Skip to content

Fix PVsyst shading import for v7#1054

Merged
cpaulgilman merged 1 commit into
patchfrom
pvsyst-shading
May 27, 2022
Merged

Fix PVsyst shading import for v7#1054
cpaulgilman merged 1 commit into
patchfrom
pvsyst-shading

Conversation

@cpaulgilman

@cpaulgilman cpaulgilman commented May 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

Fixes #530

To test:

  1. Download and extract sample PVsyst shading files, includes one each for v5, v6, and v7: https://github.com/NREL/SAM/files/5935863/pvsyst-near-shading-samples.zip
  2. In SAM, create a Detailed PV / No Financial case.
  3. Go to the Shading and Layout page.
  4. Click Edit shading for Subarray 1.
  5. Click PVsyst near shading at the top of the Edit Shading window.
  6. Read the prompt and click Yes or No as appropriate to import a shading file.
  7. Repeat 1-6 for each of the three files for v5, v6, and v7.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman added this to the 2021.12.02 Patch 2 milestone May 27, 2022
@cpaulgilman cpaulgilman requested a review from mjprilliman May 27, 2022 17:11
@cpaulgilman cpaulgilman self-assigned this May 27, 2022
mjprilliman
mjprilliman approved these changes May 27, 2022
View reviewed changes

@mjprilliman mjprilliman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I select Yes at the prompt and select the v5 file anyway, the following is the result:

image

Is this intended behavior?

@cpaulgilman

cpaulgilman commented May 27, 2022

Copy link
Copy Markdown
Collaborator Author

@mjprilliman Yes. We are relying on that prompt to convince people to make the correct choice rather than attempting to automatically identify the file version number -- hopefully the explanation of the change between v5 and v6 in the prompt is enough to help with troubleshooting. There is no version information in the file, and I don't think it's worth the effort to try to come up with a way to automatically identify the version. PVsyst is currently on Version 7, so the number of people using Version 5 should be even smaller than the small number of people importing PVsyst shading data into SAM.

@cpaulgilman cpaulgilman merged commit db7db1a into patch May 27, 2022
@cpaulgilman cpaulgilman deleted the pvsyst-shading branch May 27, 2022 19:33
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjprilliman mjprilliman mjprilliman approved these changes

Assignees

@cpaulgilman cpaulgilman

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Milestone

2021.12.02 Patch 2

Development

Successfully merging this pull request may close these issues.

Import PVsyst shade file does not work for PVsyst V7 files

2 participants

@cpaulgilman @mjprilliman