Skip to content

Linked PVWatts Battery land area calculation to cost page#1037

Merged
mjprilliman merged 2 commits into
patchfrom
SAM-1035-fix
May 11, 2022
Merged

Linked PVWatts Battery land area calculation to cost page#1037
mjprilliman merged 2 commits into
patchfrom
SAM-1035-fix

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Description

Linked PVWatts battery land area acreage to capital costs page

Fixes #1035

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added this to the 2021.12.02 Patch 2 milestone May 10, 2022
@mjprilliman mjprilliman requested a review from cpaulgilman May 10, 2022 18:59
@mjprilliman mjprilliman self-assigned this May 10, 2022
@mjprilliman mjprilliman changed the title LInked PVWatts Battery land area calculation to cost page Linked PVWatts Battery land area calculation to cost page May 10, 2022
@cpaulgilman

Copy link
Copy Markdown
Collaborator

@mjprilliman Could you fix the land area input on the Installation Costs page for Fuel Cell configurations as well? Right now land area is a user input on the Installation Costs page for both Commercial and Single Owner, but I think it should be a calculated value to be consistent with PVWatts and PVWatts-Battery configurations. (Fuel Cell / Single Owner Operating Costs page has the correct calculated value.)

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks.

@mjprilliman mjprilliman merged commit 5fe3c6b into patch May 11, 2022
@mjprilliman mjprilliman deleted the SAM-1035-fix branch May 11, 2022 17:08
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Land area for PVWatts-Battery does not update on Installation Costs page

2 participants