Wave model JPD generator UI cleanup#1025
Conversation
for folders already in library
|
@cpaulgilman could you review the label text in the 'Time Series' UI for the JPD generator button? |
|
@mjprilliman Do you have a specific request to include all of that information in the UI text? I would prefer to provide a brief description in the UI text and a more detailed description in Help. Let me know either way and I will revise the text accordingly. Also, the very wide group boxes (width = 1270) make the Wave Resource page a little harder to use. I think it would be best to limit the width to around 1000. I generally try to use the same width for all of the UI forms for a given configuration so that they don't jump around as you switch between pages, although that is not always possible. |
No specific requests on the UI text, I wasn't sure how much detail to include. Happy to get your revisions on the UI text. I will update the width of the group boxes. |
|
@mjprilliman I committed revised text for the UI. I will make revisions to Help, and commit those separately with other help revisions before the release. |
… into me_jpd_generation_cleanup
Description
-UI updates to separate wave model JPD generator into its own group box. Descriptive text with reference to marine energy standard included.
-Cleanup of file handling for adding wave resource folders to library
-Changing JPD LK functions to return name of file in order to properly index file in 'Frequency of Occurence' library
Potential direct quote from IEC/TS 62600-100 standard to include in help documentation:
“Where a time series of the wave energy resource is available the MAEP shall be calculated in accordance with mathematical Formula (12). A minimum of 10 years of wave energy resource data should be used for the calculation of the mean annual energy production. If the mean annual energy production is calculated with less than 10 years of wave energy resource data this shall be noted explicitly. The wave energy resource data set shall be unbiased, containing the number of sea-states for each month proportional to the number of days in the month.”
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.